search

c172p-team / c172p

A high detailed version of the Cessna 172P aircraft for FlightGear
GNU General Public License v2.0
82 stars 43 forks source link

Issue 1344 #1369

Closed wlbragg closed 3 years ago

wlbragg commented 3 years ago

Fixes #1302

wlbragg commented 3 years ago

@legoboyvdlp @dany93 and anyone else that wants to help, This is read to "thoroughly" test. I will also spend time testing this.

legoboyvdlp commented 3 years ago

OK. What's the order of merging. Is this linked to the FG1000 at all?

wlbragg commented 3 years ago

This would be the next issue to merge. No it's not tied to the fg1000 at all.

The FG1000 branch, which will be next after this, includes this new KAP140, but it is refactored because much of the prop-rules and autopilot calls for the KAP are moved into the variant set files instead of staying in the main set. This was done because the main set all the variants are linked to applies to all variants including the fg1000 GFC but the KAP files are not needed in the fg1000 GFC variant.

legoboyvdlp commented 3 years ago

So I don't know if I'm using it wrong; but when you engage the autopilot isn't the wing leveller supposed to hold the wings level. I engaged it in the climb out, and the servos did not seem to take over ... the plane just went into a left roll when I centered the controls.

wkitty42 commented 3 years ago

On 6/29/21 12:12 PM, legoboyvdlp wrote:

So I don't know if I'm using it wrong; but when you engage the autopilot isn't the wing leveller supposed to hold the wings level.

yes, it is supposed to... that's how/why i always use it when i fly the c172p...

I engaged it in the climb out, and the servos did not seem to take over ... the plane just went into a left roll when I centered the controls. i haven't tried in a (long) while... which version of the craft are you flying?

wlbragg commented 3 years ago

It seems to be working on mine. As soon soon as I turn on the AP I loose control of the elevator and the ailerons. The first time I did this today when testing, I was on the ground and noticed that the elevator trim was maxed out at.999. Had that happened in the air I would have surely stalled and I assume it would appear to just roll out to the left or right depending on my exact aircraft orientation. @legoboyvdlp we may have to get help testing from those intimately familiar with the KAP140.

wlbragg commented 3 years ago

@legoboyvdlp hold off for now with the testing until I find out why @reiszner @hbeni are wanting to make so many code changes to the KAP. I thought it was ready to go with maybe a small change here or there. But the there are massive changes being proposed an I don't know why that is.

hbeni commented 3 years ago

I was on the ground and noticed that the elevator trim was maxed out at.999.

That is probably expected, and part of the preflight check: When you are on the ground, wanting to use the AP, you need to verify its function on the ground. When you activate the AP and change the VS setting, that should make the trim wheel go. As the logic will never reach a satisfied VS-rate, the trim will go until you either disconnect the AP, or reset the VS setting to 0.

But the there are massive changes being proposed an I don't know why that is.

You now do :) (see other thread)

wlbragg commented 3 years ago

@hbeni @reiszner

When you activate the AP and change the VS setting, that should make the trim wheel go. As the logic will never reach a satisfied VS-rate, the trim will go until you either disconnect the AP, or reset the VS setting to 0

That is exactly what it is doing on the ground. The problem is it appears to do it in the air as well. I'll try it again, but I am sure it wouldn't hold +100 ASI in the air.

wlbragg commented 3 years ago

Hum, well it worked this time once I was airborne I was able to successfully set it and it followed the settings. You have to be spot on with your power settings or you can quickly get into trouble.

wlbragg commented 3 years ago

By the way, this branch is now up to date with all changes including some additional material and lightmap modifications.

@legoboyvdlp you can continue to test including the interior lighting both default and ALS.

As long as the autopilot is sound I am OK to have you merge this. I would like @hbeni or anyone with expert or working knowledge of the autopilot to test and verify it is working as expected. It appears to do all the basic stuff I used to do with it.

hbeni commented 3 years ago

Will do some test flights with this branch and report back! Thanks for merging :) I'm glad that this effort was going so fast (however it ate my evening, haha) :)

hbeni commented 3 years ago

Is it normal that the radio lights knob control the RPM and Oil lighting? grafik

hbeni commented 3 years ago

Tested OK! :ok: :ok_hand: Looks done for me :) The lights are okay, too :) :tada:

Details

Tested Vertical modes: (btw i didn't had the stalling issues you mentioned - but you have to be stable+trimmed (as IRL!) before activating the AP)

Tested Lateral modes:

Tested special stuff:

wlbragg commented 3 years ago

@hbeni

Is it normal that the radio lights knob control the RPM and Oil lighting?

Yeah, it's from the POH. I guess they were the most important gauges and are the only gauges that had integral lighting (material animations). The rest of the lights only had post lighting (lightmaps). But before we had the lightmaps everything was just using integral to simulate both, the two with integral and the rest with post lighting. In the shader off model mode, or low spec rendering, it's all integral.

but you have to be stable+trimmed (as IRL!) before activating the AP)

You know, that make total sense. It can be deadly if your not or you use it wrong. I wonder if you get the importance of that from the POH or manual. @legoboyvdlp I can verify this is the exact scenario I caused it to fail with, by trying to use it at takeoff and again trying to use it in the air before I was in a "trimmed and stable" mode.

Thank you so much for all your help. After seeing your cleanup of my attempt to implement this, I saw the mistakes I made and I probably would have found it, but it would have cost me more than a night I'm sure, ha!

Not to mention all the work prior in the c182s and @reiszner for the original conversion, not to forget @Octal450 for helping with the control logic. We've been wanting this upgrade for a long time.

So once again thank you all for the fantastic effort.

hbeni commented 3 years ago

It was fun to work with you all on this! And the new KAP already reached three planes, afaik!

legoboyvdlp commented 3 years ago

OK... I don't know much about it but I can't see anything obviously wrong, and it works as expected for me, a novice with the KAP140. Happy to merge!

Octal450 commented 3 years ago

It was fun to work with you all on this! And the new KAP already reached three planes, afaik!

Likewise, a real pleasure it was :) Looking forward to future collaborations.

Kind Regards, Josh

wlbragg commented 3 years ago

Thanks @legoboyvdlp Next , see: https://github.com/c172p-team/c172p/pull/1366

reiszner commented 3 years ago

Also from my side, it was a pleasure to work with you all. I think i had said it allready but i cant say it enough times. Big thanks to Josh (Octal450) for the excellent control loops and Benedikt (hbeni) to nitpick me on the smallest contradictions about the logic. This update is also a big step toward realism for the default aircraft of FGFS.