search

c172p-team / c172p

A high detailed version of the Cessna 172P aircraft for FlightGear
GNU General Public License v2.0
82 stars 43 forks source link

Fuel selector objects pointing at wrong effect file #1395

Closed wlbragg closed 2 years ago

wlbragg commented 2 years ago

Fixes #1394

@legoboyvdlp if you don't mind, when you get a chance please review, merge and close. It's minor but I can't believe we never noticed.

legoboyvdlp commented 2 years ago

Wait, if you re-added lm-interior-fuel-selector.eff but changed the object to inherit from Aircraft/c172p/Models/Effects/interior/lm-fuel, how does that work? Am I missing something?

wlbragg commented 2 years ago

@legoboyvdlp Yeah, I first pointed it to what I thought was supposed to be the correct effect file. Then I realized the issue wasn't that it was pointing to the wrong effect file at all. It was that the effect file it was pointing to was missing. So in the second commit I reversed the first commit and added the missing effect file. Let me know if that doesn't make sense to you. So, first commit was wrong, second commit reversed the first commit and added the missing effect file.

legoboyvdlp commented 2 years ago

OK - thanks - I'll try and review this tomorrow morning

wlbragg commented 2 years ago

Thank you @legoboyvdlp