c172p-team / c172p

A high detailed version of the Cessna 172P aircraft for FlightGear
GNU General Public License v2.0
82 stars 43 forks source link

Zero Hole Initiative #14

Closed gilbertohasnofb closed 9 years ago

gilbertohasnofb commented 9 years ago

3D12 - Always ZHI

gilbertohasnofb commented 9 years ago

see: https://github.com/Juanvvc/c172p-detailed/issues/15

"3D13 - Don't forget to remove ZHI easter-egg when finish (until now, two cents at the baggage, one for gsagostinho and one to ludomotico)."

gilbertohasnofb commented 9 years ago

Can we close this? I don't think we have any more obvious holes in the fuselage, so this is not really relevant IMO.

wkitty42 commented 9 years ago

actually, there may be some holes... or maybe what i'm seeing is something else??

fly at night and hit CTRL-C to light up the click spots... now use the heli view to circle about the craft... i know that i can see the left side door pocket click section for the checklists from outside... there are a few other things that appear from out there, as well...

gilbertohasnofb commented 9 years ago

@wkitty42 I can't test it now, but probably it would be better if you could take some screen shots and upload them here or on the forum, so then someone with 3D modelling skills can fix them.

wkitty42 commented 9 years ago

here's one picture i just took... this is in daylight... reproducing this is extremely easy... start fgfs with this craft... don't do anything else when it loads... simply hit CTRL-C to turn on the click spots hilighting and then hit 'v' to get to the heli view so you can move around the craft... it should start in the rear straight behind the craft... you can see the yellow click spot hilights right through the body... move around the craft and you can see more of them as you go... in this picture, i understand seeing the door and baggage compartment click hilights but not all the other ones on the control panel that you can see through the door...

fgfs-screen-015

hopefully this picture got attached correctly... if not, i'll try again...

gilbertohasnofb commented 9 years ago

But wait, isn't this true to all planes? But even if not, these are not holes, these are simply the contours of the instruments which can be toggled on and off, and when using an external view there is no point in having them on, right? I don't think this issue is about this, if I understood it correctly.

onox commented 9 years ago

This is true for all planes. The best solution would be if buttons describe whether it's for internal use or not (sometimes aircraft can have clickable doors in the exterior), but that would require changes to flightgear itself. So this issue currently seems like a wontfix.

gilbertohasnofb commented 9 years ago

To be honest I see very little benefit from a possible "fix" of the yellow contours when outside since you can turn them off when outside. But my point is that this issue #14 here was not about them, but rather about holes in the 3D model: places where you can see through where you shouldn't (for instance, with badly connected 3D objects). So I believe this issue should still be closed but for another reason: we basically fixed a lot of these holes and right now I can't see any of them in our model.

wkitty42 commented 9 years ago

maybe i'm not understanding... i thought those things were being seen through holes in the 3D model... when i first start, i can see them right through the tail end as if the seams are not fully closed... i've just loaded and zoomed in real close from the rear heli view starting point... i see now that these things are apparently showing right through the skin and paint and seats and bulkheads... some of them i can even click on and move while i'm outside the craft... ok, so i guess this is a flaw in fgfs itself... sorry for the noise...

gilbertohasnofb commented 9 years ago

No worries! So I will close this issue, and if we find some other holes we can reopen this, ok?