search

c172p-team / c172p

A high detailed version of the Cessna 172P aircraft for FlightGear
GNU General Public License v2.0
82 stars 43 forks source link

Annunciator panel is only used in a KAP140 equipped aircraft #1407

Closed wlbragg closed 2 years ago

wlbragg commented 2 years ago

Fixes #1406

wlbragg commented 2 years ago

@dany93 This is a minor bug fix.

Test to see that the KAP140 still works in all variants including the FG1000 KAP140 variant. Before pulling if you run the FG1000 GFC variant, you should see a nasal error concerning the "annunciator" in the log. After this correction the error should be gone.

There are other pieces of equipment code in the 2 FG1000 variants that could eventually be removed and added to the variants that have that equipment including the KMA20, KI266 and KX165.

dany93 commented 2 years ago

@wlbragg

Confirmed. FG1000 GFC700, before pulling:

   74.31 [INFO]:nasal      Annunciator panel: initialized
   74.31 [ALRT]:nasal      Nasal runtime error: setprop() value is not string or number
   74.31 [ALRT]:nasal        at /home/dany/FG/github/c172p/Nasal/annunciator_panel.nas, line 212
   74.31 [ALRT]:nasal        called from: /home/dany/fgfs-A/install/flightgear/fgdata/Nasal/globals.nas, line 137

After pulling: No Nasal/annunciator_panel.nas error.

Tests: With FG1000, I cannot do FG1000 tests because I have 2 to 8 fps, with graphics not complete. Crappy. Moreover, the rare figures I see are very small. My hardware (graphics card most probably) is insufficient.

However, I more or less could fly and test the KAP140 with FG1000 + KAP 140 : the KAP140 works. With The Default aircraft (160 hp), the Amphibious (180 hp) : the KAP140 works too.

On FG1000-KAP140, Default (160 hp) et Amphibious (180 hp), I see [INFO]:nasal Annunciator panel: initialized

Are these tests sufficient to say that I can merge? Or do I have to test all other variants too?

Something I don't understand: where is this annunciator? What is its connection with the KAP140?

wlbragg commented 2 years ago

@dany93

Something I don't understand: where is this annunciator? What is its connection with the KAP140?

It's the KAP140 panel, the one that beeps when it starts up and you see all the different functions for a second when it inits. Then it goes to BAR mode for adjustment.

It took me awhile to figure it out myself, The file name was c182p-annunciator.xml. I almost thought it got in there accidentally, then remembered the new KAP went into the c182 first and realized it came over with the new KAP140.

Yes, I am confident in this minor change. You can merge.

wlbragg commented 2 years ago

@dany93 Thank you!