Improve and bugfix the ground services system

[wlbragg]

This issue fixes some issues with the ground services system including the following.

Refactors the tie down system to eliminate the possibility of bouncing on startup when the tie downs are saved in the installed state. Adds a second ladder. Adjusts ground equipment to account for the various variants. Add sound to the engine preheat system. Correct a bug that was duplicating ground equipment and leaving them in a state where they could no longer be removed.

Still need to finish... Add the logic to warm the engine when the preheater system is activated.

[wlbragg]

@dany93

After much contemplation I feel the menu system for the c172p is getting somewhat disorganized and confusing to navigate. I want to rearrange the main aircraft menu and the submenus to something more organized and easier for the user to use.

I will make a new issue and proposal but not push any work until this issue is merged. I bring it up here because part of the menu reorganization is happening in this issue because the ground services work is a part of that reorganization. Even if we don't follow through with a total reorganization of the menu system, I feel the changes here are helping to alleviate the growing size of the main menu. I think once I present my proposal for further changes in the next issue it will make sense and be happily accepted.

[dany93]

@wlbragg You are right, the ground services are better classified. It was confuse. The "Enable wheel chocks" cannot be checked( it unchecks by itself).

Shouldn't "Install cowl grill" be in "Ground Services"? (even if being able to install / uninstall it in flight is convenient for tests... cheating). However, it is not a "Secure aircraft" item... (After reading https://github.com/c172p-team/c172p/issues/1458, I see that you already had this reasoning)

[wlbragg]

You are right, the ground services are better classified. It was confuse.

Oh, good, I'm relieved you agree.

The cowl grill, I had one thought that I should leave it near or with the Enable fog, frost and icing. Maybe indent it where it currently is like we do the ground unit.

Moving it to Ground Services make a lot of sense as well. But I wasn't sure exactly where I should put it.

However, it is not a "Secure aircraft" item...

That was my thought as well. Maybe it would need its own heading or just its own block.

[dany93]

@wlbragg wrote

Maybe indent it

("Install Cowl Grill" below "Enable frost,...", in "Aircraft Options") The most intuitive IMO. It would be my preference.

The others (in Ground Services) are more rigorous. But indirect.

"Ground Services" might be named "Ground Operations" (or a better wording if you have one). Power Unit and Fuel tank are "Services". Which can be classified in "Ground Operations". Control lock, wheel chocks, ties-downs, etc... rather are "Operations" (? my English??).

[wlbragg]

I like Ground Operations!

Now "Install Cowl Grill" fits well at the top under the main heading, but I do like it with the icing.

I think it needs to stay with the "Ground Operations".

[dany93]

So, right. Tell me when your https://github.com/c172p-team/c172p/pull/1457 PR is ready for merging.

[wlbragg]

Ok, will do.

One more thing. I don't like the lines separating all the ground equipment in the "Ground Equipment" category. It's confusing. I don't think it needs them. I see why it was done originally, but again, unneeded? For consistency, I am going to change External heater applied to... Apply external heater? Connect external heater? Connect external heater to engine? Connect external heater to aircraft? and Enable left/right ladder to.. Place left ladder? Place right ladder?

[dany93]

As you like for the Ground Equipment line deletions. You might be right, cleaner.

Apply external heater? Connect external heater? Connect external heater to engine? Connect external heater to aircraft?

I don't know for this level of detail. For the last one, does it mean "...to cockpit?"?

OK for "Place left/right ladder?"

[wlbragg]

does it mean "...to cockpit?

No it is to the engine compartment. The heater blows hot air into the cowling.

[dany93]

What's the difference with.. "...to engine?"? Or will it be one or the other in the lines? As "Apply..." or "Connect..."?

[wlbragg]

To engine, would not be right, It's not really connect to the engine. Not really even connected to the aircraft. It is the past tense use of applied that bothers me. We "Place" the Ground power unit and then connect the GPU to the aircraft. That is correct. If we use Place external heater, then we still need to turn it on. So I don't like that. Appling external heat is the exact thing we are doing, We are not Applying the external heater.

I know I am getting hung up on something of little importance. I think either leave it alone or change it to Apply external heat or Use external heater?

[dany93]

change it to Apply external heat or Use external heater?

Yes, that could be right too.

However, "connect" or "connected" is not that wrong, there is an air flow.

[wlbragg]

@dany93

I think I'm done with this. Please do final test and if you approve of the menu headings go ahead and merge https://github.com/c172p-team/c172p/pull/1457

[dany93]

@wlbragg

• Install cowl grill: correct
• Place right ladder: worked at the beginning; but after a few clicks, no longer works for ladder removing. And the button unchecks by itself as soon as after having been clicked.
• Same for place right / left safety cone : worked once; but after a few clicks, no longer works
• Same for Fuel tank trailer,
• Same for Place ground power unit.

Not easy to decipher. Most or them seemed to work at first, then they stopped after a few clicks on different buttons.

At second launching, the effects work again (ladders, cones, tank trailer, power unit appear / disappear): everything seems correct for the objects. But which is reproducible is that the buttons uncheck by themselves as soon as after having been clicked.

[wlbragg]

Wow, I had that issue as well and I thought I fixed it. OK, let me check it out.

[wlbragg]

@dany93

Ok, I found it. you can't have dialog-update and dialog-apply in the same menu, at least with the "load models". When I moved "Install cowl grill" over I forgot to change it. Also I needed to add a check for Cowl grill and Cowl plugs as you can't use both at the same time. Plugs won't fit if the cowl grill is installed.

The only other thing I noticed is that if I click on objects too fast, going up and down the GUI options, sometimes it gets confused and a cone or ladder will still be visible but not checked, checking it again resets it and it still works. Not to be confused with the condition you described, that should be fixed now.

[dany93]

Merged.