Apply new click sounds to switches

[gilbertohasnofb]

Apply new click sounds to cockpit switches (lights, master, avionics switch, etc.). Should be fairly soft.

Could you give me a hand with this, @onox?

[gilbertohasnofb]

These are the properties that, when changed, should activate this click sound:

/controls/lightning/taxi-light /controls/lightning/landing-lights /controls/lightning/nav-light /controls/lightning/beacon /controls/lightning/strobe /controls/anti-ice/pitot-heat /controls/switches/master-avionics /controls/engines/engine/master-bat /controls/engines/engine/master-alt

[onox]

I'll do this in a separate branch, closing #85 without a PR felt so unnatural :confused: :smile:

I won't use positions for these, that would be a bit overkill.

[gilbertohasnofb]

No worries and no rush, do it the way you like better. I personally love to close the issues that I just solved myself :smile:

[onox]

hehe.. yeah, but new stuff should enter master via PR so it can be properly tested. But I think I have said this a thousand times before :grinning: :laughing:

[wkitty42]

:+1:

[gilbertohasnofb]

For when this gets implemented: we now have three click sound files in Sound, click.wav, click2.wav and click3.wav. My idea is:

• click.wav should be used for the small switches (taxi-light, landing-lights, nav-light, beacon, strobe and pitot-heat)
• click2.wav should be used for the master switch (master-bat and master-alt)
• click3.wav should be used by the avionics switch (master-avionics)

Since these files are super small, it makes no difference to have more variety, and it certainly brings some ear candy to the plane :wink:

[wkitty42]

haha! and here I thought the clicks were already implemented and I wasn't hearing them for some reason... was thinking something was wrong over here but had not yet written up an issue... I'll wait for them to be implemented :wink:

[onox]

I'll try to apply the new sounds tonight or tomorrow.

[wkitty42]

:+1: no problem! :laughing:

[gilbertohasnofb]

@onox ok, let me know how it goes and if you need anything that I can help with related to the sounds.

[onox]

You could help me by finding an ambient/background sound of "something floating on the water", but that's not related to this bug :smile:

[gilbertohasnofb]

You could help me by finding an ambient/background sound of "something floating on the water"

Sure! You mean a sound of something moving through water or simply floating still? (which begs the question, do things floating still make any sound?). For this, let's use https://github.com/Juanvvc/c172p-detailed/issues/264

[onox]

@wlbragg Are you able to determine (x,y,z) coordinates of objects in the 3D model?

[onox]

@gilbertohasnofb Which sound do you want for the circuit breakers?

[onox]

More dials and switches that could use sounds:

1. Primer, throttle, mixture, air heat, air flow
2. Flaps
3. Magneto's
4. Circuit breakers
5. Parking brake
6. Carb heat
7. Dials: instrument lighting, attitude horizon offset, heading offset, heading bug, altimeter, nav1/nav2/adf radial/heading
8. Doors
9. Trim wheel
10. Buttons and dials of radio stack

[gilbertohasnofb]

Which sound do you want for the circuit breakers?

Please use click.wav

More dials and switches that could use sounds

I will work on them all and report here.

[onox]

@gilbertohasnofb I think the circuit breakers should have a sound that sounds like a button being pushed in and then moves little bit back.

[gilbertohasnofb]

Okay, working on it then.

[onox]

Can you add any new sounds for this bug to the bug-238 branch? Do git fetch and then git checkout bug-238.

[gilbertohasnofb]

Sure onox, I can do that, but also let me ask you something: I completely understand why you ask people dealing with code to use PRs or different branches to upload their work, but does this make any sense when comes to textures and sounds? I mean, they can't break anything and testing means simply looking or hearing, right? Or am I missing something here? I am asking this very sincerely, as you know much more about git than I do and very likely I am missing something..

[onox]

Well, otherwise I have to merge master to bug-238 all the time to get the sounds when you make a change to the sounds and that will make the graph (history) more complicated than necessary.

[gilbertohasnofb]

Oh, I see. But in the general case of textures, I can continue to simply push them to the master, right?

[onox]

But the textures and sounds don't break anything, that's correct. About water-fast.wav and water-still.wav: that's ok to add to master directly because I haven't started working on #264 yet.

[onox]

Yes.

[gilbertohasnofb]

Cool, thanks! I was meaning to ask you this for some long time but it had slipped my mind :smile: So the next sounds for the switches will go to bug-238

[onox]

Yeah, just the sounds for the switches :smile: Unrelated sounds can go to master.

[onox]

@gilbertohasnofb Have you already committed any sounds locally? Otherwise I can commit the circuit breakers in the mean time.

[gilbertohasnofb]

Everything is ready, I am uploading them now.

EDIT: to be more exact, I am fetching the whole repository. My internet is really slow... :disappointed: but just give me a minute or two and everything should be up

[gilbertohasnofb]

onox, this git fetch is taking ages. Would it be all right if I simply push these files to the master? Sorry but my internet is not cooperating today and I will have to wait the whole night for it to finish fetching if it keeps at this speed...

[onox]

Can you wait for fetch 5 more minutes? :open_mouth:

[gilbertohasnofb]

Ok, let's try a bit longer, but right now it's on 23% and I am waiting for almost 10 minutes, and soon I need to go (I am a night owl but tomorrow I must wake up early). How large is the whole repository, would you know?

[onox]

I don't know, but you have a recent version, right?

[gilbertohasnofb]

Well, normally I am just pulling the master and it was up to date, but I don't ever use git fetch. Since I never use different branches I normally just pull, then add, commit and push.

[onox]

Ok, can you cancel git fetch and then just try to do git checkout bug-238?

[gilbertohasnofb]

Just did that, I get: error: pathspec 'bug-238' did not match any file(s) known to git.

Alternatively, I could also upload it on some sharing service so you can download and push it yourself. Sorry onox, but my internet is really bad at home. Tomorrow at my university I will fetch the whole repository again.

[onox]

What if you do git pull?

[gilbertohasnofb]

Hmm, before it was telling me I was up to date, but since I cancelled the git fetch I now need to download 5000 files.

[onox]

Uh? Just do git fetch tomorrow then on the university. I need to sleep too :smiley: :zzz:

[onox]

And then just add those sounds to bug-238. Should be no problem if git fetch succeeds.

[gilbertohasnofb]

Ok onox, so I will push those sounds tomorrow in the afternoon then. Thanks a lot!

[gilbertohasnofb]

Tomorrow I will clone the whole repo again from at uni to make sure everything is working well, then I push those sounds.

[onox]

Ok, nvm, just do git fetch tomorrow when you have fast internet. No worries :+1: :smile:

[gilbertohasnofb]

Ok, to be continued then!

[wkitty42]

wow! 5000 files?? something isn't right... i don't know what but i've not had to pull 5000 files for anything...

[gilbertohasnofb]

wow! 5000 files?? something isn't right...

Yes it is. Try cloning the repository into a new folder and you'll see that the total number of files is around 5000. Normally a pull just grabs what is new, but something went wrong with my directory and I am cloning it again.

[gilbertohasnofb]

@onox the new files are pushed. Here is what to do with them:

Primer, throttle, mixture, air heat, air flow, carb heat: no sound (I don't think they make any noticiable sound, at least I couldn't hear it watching videos of the aircraft"

1. [x] Flaps: keys2.wav
2. [x] Magnetos: keys.wav and keys2.wav (can we randomize them or alternate or at least assign one to L and BOTH and the other to OFF and R magnetos?)
3. [x] Circuit breakers: double-click.wav (should be really really soft)
4. [x] Parking brake: lever.wav
5. [x] Dials (instrument lighting, attitude horizon offset, heading offset, heading bug, altimeter, nav1/nav2/adf radial/heading): scroll.wav
6. [x] Doors: door-opening.wav and door-closing.wav (remember to position it left and right according to which door is being used)
7. [x] Trim wheel: scroll.wav
8. [x] Buttons and dials of radio stack: use double-click2.wav for buttons and scroll.wav for dials
9. [x] Buttons and dials of comm/nav radio's and transponder

And one of the sounds is CC attribution, so we need to add this to some sort of "thanks" file (what's the best way of doing that?): - Thanks to DrMinky for the "Old Lever Pull" sound: http://freesound.org/people/DrMinky/sounds/167048/

[onox]

@gilbertohasnofb I am going to work on the sounds now :smiley:

[onox]

Parking brake, magnetos+starter, and flaps do not make any sound yet when using the keyboard.

[gilbertohasnofb]

Hi onox, I just tested your branch and here are some comments:

• I can't hear flap sounds even when clicking on them
• the dial sounds are too loud IMO. I'd make them barely audible when the engine is at high RPM.
• the masters switch sound (both ALT and BAT) are a bit buggy. Try clicking on them constantly (let's say 3 times a second): sometimes they will play fine but sometimes they will play a broken sound (quite unpleasant)
• light switches also got a bit buggy: in the beginning they were fine, but after I started the engine, they were sometimes making proper sounds and sometimes silent! They were almost alternating between sound/no-sound at one point

[gilbertohasnofb]

I also added a phrase to the Thanks file about the parking break sound.