search

c172p-team / c172p

A high detailed version of the Cessna 172P aircraft for FlightGear
GNU General Public License v2.0
81 stars 43 forks source link

Engine should be killed if propeller is broken #608

Closed onox closed 8 years ago

onox commented 8 years ago

Engine should be killed if propeller has stopped (broken). This should also happen if you for example break the propeller by collapsing the nose gear.

Can be fixed by using /engines/active-engine/killed. It seems it is currently used in the animations (that is good), but not by the FDM or engine systems (because if I set full throttle, I still get RPM). Engine is still running in this screenshot:

fgfs-screen-403

dany93 commented 8 years ago

The reference should be Systems/fuel.xml. But there is an extra layer above /engines/active-engine/killed, which prevents from stopping the engine by directly setting this property to true. I know neither why nor where. Propeller stopped in animation should be a consequence of engine stopped, not something independent or upstream.

wlbragg commented 8 years ago

Can you bust a pin or spin it off the shaft?

wlbragg commented 8 years ago

This should also happen if you for example break the propeller by collapsing the nose gear.

This for sure used to be in place, I set it up myself. So it must have got removed accidentally?

onox commented 8 years ago

If I print something in killengine it gets printed, but /engines/active-engine/killed remains false.

onox commented 8 years ago

It seems it might be Systems/engine.xml that is resetting it.

onox commented 8 years ago

I have fixed it.

onox commented 8 years ago

@gilbertohasnofb What's the purpose of the settimer() in engine_coughing in Nasal/engine.nas? Is it 1) to just make a coughing sound; or 2) make coughing sound + temporarily kill engine?