c172p-team / c172p

A high detailed version of the Cessna 172P aircraft for FlightGear
GNU General Public License v2.0
80 stars 43 forks source link

Back tip of the fuselage has strange reflection #966

Closed gilbertohasnofb closed 6 years ago

gilbertohasnofb commented 6 years ago

Back tip of the fuselage has strange reflection, it is brighter than the fuselage from nearly all angles.

wlbragg commented 6 years ago

@gilbertohasnofb I'm not seeing this anymore, please confirm!

gilbertohasnofb commented 6 years ago

I'm not seeing this anymore, please confirm!

I just did a pull on branch issue-860 and I can confirm I am still experiencing this. Are you sure you pushed your fix?

wlbragg commented 6 years ago

I don't see that, I even used that livery to test it. It must be a certain lighting condition your in. Can you give me a clue as to your lighting, maybe location and weather settings? I can try again and move the aircraft around to all the compass directions and see if I can reproduce. But, look at the fairings, notice the edges who's faces are pointing the same direction as the tail section that is so bright. They appear to be just as bright only smaller so you don't notice it. I'm thinking it might just be the angle that is catching full sunlight? If it is, there is nothing we can do other than maybe changing the mesh at the tail to taper instead of go to such an extreme, flat angle.

gilbertohasnofb commented 6 years ago

Ok, so this is a test at LKCE

fg-0 fg-1 fg-2 fg-3

note that I have all shaders enabled:

fg-4

This is another test at SAWB:

fg-5 fg-6

So this is what I conclude from what I can observe on my side:

gilbertohasnofb commented 6 years ago

And just confirming, I am at issue-860 and just did a git pull, for which I am told Already up-to-date.

wlbragg commented 6 years ago

@onox, do you see what @gilbertohasnofb is seeing?

wlbragg commented 6 years ago

OK, I am able to recreate it on LKCE runway when the sun is rising. It is definitely the light reflecting, Use the accelerated time and watch it disappear to normal. I don't get the red tint your seeing, just the brightness. I don't know exactly what to do about it either. If you were to change the material settings and darken it up then the rest of the aircraft will do the same. Maybe make that part a separate mesh and make its material settings not so reflective. I'm currently testing changes to blender settings to see what if anything I can do.

wlbragg commented 6 years ago

By looking at other like aircraft (c182s) I am almost positive this is a mesh design issue. It is simply flat in back and is catching the light accordingly. If you look at the back of the c182s in similar light conditions you can see the same thing only because of the tapering of the mesh it is a much smaller spot. I am going to try to reshape the tip of the tail but that is going to have an adverse affect on the liveries. Hopefully I can remap it to work OK.

wlbragg commented 6 years ago

Oh, you might ask why the c182p in fgaddon isn't as bad, it is because the mesh is screwed up back there and actually helping to break up the flat surface.

wlbragg commented 6 years ago

I am still not sure why your seeing "red" On mine I only see brightness. I pushed a change to the ac just now. That is as much as I think I am going to be able to do. What I did was create several edge rings on the tail and tapered it like the c182s does. It may have helped some. @gilbertohasnofb There is a test I would like you to try, start out on the runway (LKCE), morning, crank the wheel hard left (rudder hard right). with engine idling let off the brake and let the aircraft pivot until it is 90 deg on the runway (like blocking it sideways instead of trying to go down it). Watch what happens to the light on the tail face and the side of the fuselage facing the sun. You should see the light change to where the tail face (the one that is so bright) goes darker and the side of the fuselage turns just as bright as the tail face used to be. Questions Does that all look normal as that happens? Does the side of the fuselage that is facing the sun start to get that red cast to it?

By the way, a side note. The rudder was really bent to port, I straightened it out. screenshot_2018-02-15_10-32-12

Test to see if the light changes as it should. fgfs-screen-022

Before mesh tail change and rudder straightening fgfs-screen-019

After mesh tail change and rudder straightening fgfs-screen-023

wlbragg commented 6 years ago

If this doesn't work for you I may make one more pass and ty to make the tail taper less extreme, as in over greater depth instead of so flat. But that requires changing the design of the tail and I need to look at some reference images to make sure I can even do that. WE NEED A NEW MODEL. There are so many issues it isn't funny.

Before screenshot_2018-02-15_10-32-47

After screenshot_2018-02-15_11-55-57

The nose sucks as you can see, but I remapped it so at least the white is gone. screenshot_2018-02-15_11-40-48

Oh, before I forget, I need to only save the Blends when we're all done instead of every revision as they exponentially increase the size of the repository on ever revision and push.

gilbertohasnofb commented 6 years ago

WE NEED A NEW MODEL. There are so many issues it isn't funny.

I know, @wlbragg, this has been a huge issue for sometime already. Creating a new model is a huge task, but at the same I just keep thinking of how much time we invested trying to fix the current one. There are so many issues indeed. My main one is actually the cockpit position which is really too low in relation to the fuselage and makes it look all wrong, completely ruining the main cockpit view in my opinion and looking very different and unrealistic from the real thing (this is my biggest annoyance with our model, I absolutely hate that cockpit view...). But with all this said, I truly appreciate what you have done and these efforts to improve the current model do not go unnoticed. Many, many thanks.

If you look at the back of the c182s in similar light conditions you can see the same thing only because of the tapering of the mesh it is a much smaller spot.

This is true, I just checked and the c182s suffers from the same issue:

fg-3

Maybe this is just a limitation of how our reflection effect looks, unfortunately. We could perhaps try the best we can to minimize this issue at the back, but I see there is nothing much to be done.

If this doesn't work for you I may make one more pass and ty to make the tail taper less extreme, as in over greater depth instead of so flat. But that requires changing the design of the tail and I need to look at some reference images to make sure I can even do that.

I would be happy to try whatever you can come up with! I just tried the newest modifications but the problem is still very apparent. I also noticed that the very back of the rudder is showing this issue, was there some modification to that object as well or that is just because my image below is zoomed?

fg-0

The nose sucks as you can see, but I remapped it so at least the white is gone.

But many thanks for fixing this, it looks a million times better!!!

wlbragg commented 6 years ago

I would be happy to try whatever you can come up with! I just tried the newest modifications but the problem is still very apparent.

I have two possible ideas. 1) I'll try to do the taper thing I already mentioned 2) If that doesn't work, what about changing the color or brightness of the texture in that spot. Like make it gray? Problem is all the liveries will have to be edited and when not in the light it will maybe appear too dark?

I also noticed that the very back of the rudder is showing this issue, was there some modification to that object as well or that is just because my image below is zoomed?

I'm sure it was always there, your just now noticing it because it is zoomed in. I did modify the back edge of the rudder though because it was really bent. However I didn't change any dimensions, just straightened it.

From looking at your last screen shot at least I now know why you had what appeared to be a really red tint. I didn't realize it was the livery itself. At a distance it looked like only the tail face was red tinted.

gilbertohasnofb commented 6 years ago

what about changing the color or brightness of the texture in that spot. Like make it gray? Problem is all the liveries will have to be edited and when not in the light it will maybe appear too dark?

Changing all liveries is not the problem (I would gladly do that if necessary), the problem is that I don't think this solution would look very good. As you pointed out, in a more uniform light the aircraft would have a dark tail. But on top of that, this would look unrealistic as the real liveries are painted in colour in those areas, e.g.:

Now something I noticed looking at this picture above is that we seem to have one more 3D model issue which might be the main contributor to this problem here. Notice how the fuselage gets thinner and straighter and leads directly to the rudder. In our case, we have those oval intersections of the fuselage ending and then starting a very straight rudder. perhaps if we were to deform a bit the fuselage so that it would lead into the rudder and there would be no normal surface pointing to the viewer from the angle of the screenshot in the post above.

wlbragg commented 6 years ago

In our case, we have those oval intersections of the fuselage ending and then starting a very straight rudder.

Interesting, your right. That goes hand in hand with my statement about changing the shape of the tail. The above picture verifies we technically or realistically could do this. Lets take that approach and see what we get.

wlbragg commented 6 years ago

OK, some new mesh to critique... fgfs-screen-027

fgfs-screen-028

fgfs-screen-029

I am sure hoping this is close to finished!

gilbertohasnofb commented 6 years ago

I am sure hoping this is close to finished!

This is looking really great!!! 👏

wlbragg commented 6 years ago

One more thing. We talked about re-texturing the the end face of the tail. But we were concerned about making it darker. I remember seeing a picture on the Internet of the tail end of a c172p and it appeared to have mechanical stuff on the tail face. Also it was quit dark and in the shadows. My point being, a texture to simulate what that image portrayed might still be in order so when you are using rudder instead of seeing a shiny face you would see something a little more realistic. I'll see if I can find the image for an example.

wlbragg commented 6 years ago

This kind of shows what I am talking about. tale1

gilbertohasnofb commented 6 years ago

it appeared to have mechanical stuff on the tail face

I will try to come up with something, I will push it to the 4X-CHV texture tonight and then it could be applied to all liveries. I will let you know.

gilbertohasnofb commented 6 years ago

@wlbragg Actually, I found some excellent pictures of the tail of a 172 and as you can see there is no need for a metal/mechanical texture, it's all painted in livery colour:

wlbragg commented 6 years ago

That second picture is really helpful for the semicircle. I think I need to adjust ours a bit. Also the back face (the face hidden by the rudder) is flat and not tapered at all. The bottom edge of the rudder is rounded and not square.

Do you think the little rectangle below the horizontal stabilizer with what looks like a cable or wire sticking out of it going to the rudder is light wires or cable for the rudder movement? If for rudder movement, do you think then there is one on both sides of the fuselage?

dany93 commented 6 years ago

Do you think the little rectangle below the horizontal stabilizer with what looks like a cable or wire sticking out of it going to the rudder is light wires or cable for the rudder movement? If for rudder movement, do you think then there is one on both sides of the fuselage?

For the C172P I don't know, but yes, I've seen that on Ultralights for the rudder, one cable on each side. SkyRanger p. PDF 92/283, Fig 116. You will probably receive better responses, but just in case...

Also see C172S POH PDF 177/384, p. 7-7 Fig. 7-1.

I'm worrying. Will these 3D improvements not degrade the fps (fluidity)? Up to now, it was very good for such an aircraft.

gilbertohasnofb commented 6 years ago

Do you think the little rectangle below the horizontal stabilizer with what looks like a cable or wire sticking out of it going to the rudder is light wires or cable for the rudder movement? If for rudder movement, do you think then there is one on both sides of the fuselage?

I think this cable is on both sides, I will try to find a picture.

I'm worrying. Will these 3D improvements not degrade the fps (fluidity)? Up to now, it was very good for such an aircraft.

We are barely adding any new polygons, we are mainly cleaning the current mesh. I am sure the performance difference will be negligible. Feel free to try the PR where this work is being done and report any performance issues if you see any.

dany93 commented 6 years ago

I think this cable is on both sides, I will try to find a picture.

Almost sure, the cable is on both sides.

algefaen commented 6 years ago

Do you think the little rectangle below the horizontal stabilizer with what looks like a cable or wire sticking out of it going to the rudder is light wires or cable for the rudder movement? If for rudder movement, do you think then there is one on both sides of the fuselage?

Rudder control cable. Pretty symmetrical for both sides.

gilbertohasnofb commented 6 years ago

Here is an excellent close up of Airfoil Labs's Cessna 172 SP, though the SP is a much more modern aircraft than our P model:

Here is a photo of an older model, possibly even a P. You can magnify it to check the tail details:

wlbragg commented 6 years ago

I'm worrying. Will these 3D improvements not degrade the fps (fluidity)? Up to now, it was very good for such an aircraft.

I think there has been very little net gain. Some of the change are actually cleaning up some really messed up mesh so it's possible we will see an improvement in performance.

If anyone is really worried about adding more eye candy such as rudder cables, etc. please do check performance along the way and speak out if you notice something that causes a hit.