Missing search fields - Githubissues

c2corg / v6_api

REST API for https://www.camptocamp.org

GNU Affero General Public License v3.0

22 stars 26 forks source link

Missing search fields #311

Closed asaunier closed 8 years ago

asaunier commented 8 years ago

I will add here the search fields that proved missing while implementing the UI advanced search (see https://github.com/c2corg/v6_ui/pull/373):

[x] waypoint prominence "prom" https://github.com/c2corg/v6_api/blob/master/c2corg_api/models/waypoint.py#L37
[x] waypoint's climbing_outdoor_types https://github.com/c2corg/v6_api/blob/master/c2corg_api/models/waypoint.py#L52
[x] waypoint's climbing_indoor_types https://github.com/c2corg/v6_api/blob/master/c2corg_api/models/waypoint.py#L55

Fields that are probably not needed (to be confirmed):

[x] has_phone https://github.com/c2corg/v6_api/blob/master/c2corg_api/search/mappings/waypoint_mapping.py#L21-L22

tsauerwein commented 8 years ago

What fields are you listing here? The fields that are indexed in ElasticSearch?

asaunier commented 8 years ago

Yes, for instance the ones in https://github.com/c2corg/v6_api/blob/master/c2corg_api/search/mappings/waypoint_mapping.py

tsauerwein commented 8 years ago

prominence, climbing_outdoor_types and climbing_indoor_types are added in #324.

tsauerwein commented 8 years ago

I am closing this issue with https://github.com/c2corg/v6_api/pull/324 being merged. If there are other fields missing, a new issue can be opened.