Quality attribute should be saved in table guidebook.documents_locales

[asaunier]

not in guidebook.documents because it may be different between 2 locales (lang) of the same document.

[asaunier]

As reported in https://github.com/c2corg/c2c_ui/issues/992

It seems an issue in the API, as the quality attribute is part of the generic Document model: https://github.com/c2corg/v6_api/blob/master/c2corg_api/models/document.py#L43-L61

That does not make sense as a document may have a very good version in a language but be very poor in another one. Eg.

• https://www.camptocamp.org/waypoints/113031/fr/cabane-monte-leone-cas => FR = good
• https://www.camptocamp.org/waypoints/113031/de/monte-leone-hutte-sac => DE = draft (but marked as good because of the FR version). If switching down to draft, the FR version is made "draft" as well :/

[cbeauchesne]

Considering the direction we took on https://forum.camptocamp.org/t/vote-champ-completude-qualite/253410, here is a small specs proposition :

• a quality field must be added on each locale
• it can be null (we set it to medium by default on v6, it introduced a huge noise, and made it quite unusable for existing documents)
• old quality field must be removed
• Migration :
  • If quality is medium and if it has never been changed since the V6 migration, then there is a good chance that it's the defaulting, and not the real value => set it to null
  • otherwise, set new quality fields to the same value as the old one
• Requests
  • if qa argument is set, then 'l' (lang) argument must be set. Otherwise, it has no effect
  • if qa=null, it returns document with quality field equal to null

[asaunier]

I have assigned the issue to myself to have a look at it later. Feel free to reassign to you if motivated to do the change.

[AntoineMarnat]

@asaunier, any progress on this ?

https://github.com/c2corg/c2c_ui/issues/1554