search

c2corg / v6_ui

UI for c2c.org v6
GNU Affero General Public License v3.0
7 stars 12 forks source link

Route creation: select the first waypoint as main waypoint by default #1165

Closed brunobesson closed 7 years ago

brunobesson commented 7 years ago

Currently, no waypoint is by default the main waypoint, thus users create routes without prefixed name.

Several possibilities:

desnoes commented 7 years ago

fixed on demo. There is a small traduction issue, i have translated the string ' unset main waypoint' in transiflex.

fbunoz commented 7 years ago

The problem came back with the last prod update.

asaunier commented 7 years ago

I have just tested with FF 50.1 on the demo and observed no problem: http://www.demov6.camptocamp.org/routes/828342/fr/un-itineraire-pour-main-wp-par-defaut (I have created a route and only associated the WP => it has been made the main WP directly with no additional action, as expected).

Changes propaged to production recently seem to have no relationship with this feature:

Image title should not be required when editing an image Incorrect WP longitude validation Add pagination buttons at the bottom of advanced search results Image upload: copyright should be allowed only for moderators Map scale design Ergo / Design Outing creation: the route search engine is confusing fixed WP 'Access': display errorfor the field "Type de transport en commun" Comments in topoguide Add possibility to enlarge or hide map in the advanced search pages Show link "more results" only for the main simple search tool Sitemap in prod have an error Cropped dropdown in following page No close outing end date button on mobile Lien profil topoguide -> profil forum

desnoes commented 7 years ago

I didn't notice any problem since the last update. @fbunoz: would you check again? If you do not observe the problem, please close the issue.

desnoes commented 7 years ago

I have juste tested on desktop (Chrome) on both the demo and the site, it works as expected. @fbunoz and @stef74 : would you please check quickly ? Otherwise i will close this issue.

stef74 commented 7 years ago

what is the test ?

desnoes commented 7 years ago

According to Bubu, there is a bug in the selection of a WP by default. Alex and i think it works fine.

----- Mail original ----- De: "stef74" notifications@github.com À: "c2corg/v6_ui" v6_ui@noreply.github.com Cc: "desnoes" mathieu.desnoes@free.fr, "State change" state_change@noreply.github.com Envoyé: Jeudi 12 Janvier 2017 10:42:18 Objet: Re: [c2corg/v6_ui] Route creation: select the first waypoint as main waypoint by default (#1165)

what is the test ?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub , or mute the thread .

stef74 commented 7 years ago

So I have to create a new route et add a WP ?

desnoes commented 7 years ago

So I have to create a new route et add a WP ?

yes

fbunoz commented 7 years ago

So I have to create a new route et add a WP ?

Yes. But test also by creating a new route from the WP page : the WP is automaticaly associated, but it is not defined as main WP. Ex : https://www.demov6.camptocamp.org/routes/828353/fr/creation-d-un-itineraire-depuis-la-page-d-un-wp-il-n-est-pas-mis-en-wp-principal-par-defaut

In prod, several routes has been created from a WP, without defining a main WP. As a main WP is useful for the most routes, it's better to define the first associated WP as main by default when creating a route.

desnoes commented 7 years ago

@asaunier: do you have enough instructions ? It seems the explanations from @fbunoz are sufficient, aren't they ?

fbunoz commented 7 years ago

When we create a route from the page of a WP, the WP is automatically associated, but it is not set as main WP. Ex : https://www.camptocamp.org/routes/add#w=841309 (see the associated WP : it is not set as main WP).

fbunoz commented 7 years ago

It works fine on the demo :-) I need test on mobile, but it should work.