c2corg / v6_ui

UI for c2c.org v6
GNU Affero General Public License v3.0
7 stars 12 forks source link

Translations missing in Transifex #627

Closed shortoland closed 8 years ago

shortoland commented 8 years ago

The following strings are now translated in last french version, and also not present in Transifex:

image1

Choices for "Configuration" and "Qualité du document" are not translated:

image2

image3

image4

image5

image6

image7

image8

image9

image10

image11

asaunier commented 8 years ago

OK, thanks for the report.

@fbunoz has already made a related report at https://github.com/c2corg/v6_ui/issues/602 I copy-paste here his example and close it as duplicate.

Il manque toutes les options des champs :

  • route_type
  • route_configuration_type
  • climbing_outdoor_type
  • rock_type
  • cotation globale alpi (et oui, en DE ce ne sont pas les même symboles)
  • matériel de glacier
  • déneigement
  • type de transport en commun
  • public_transportation_rating
  • climbing_styles
  • pluie
  • adapté aux enfants
asaunier commented 8 years ago

@shortoland @fbunoz I have pushed changes that fix most of the missing translations I think. There are still some strings that are not translated yet (simple search and some map tools). The new strings have been pushed to Transifex and are ready to be translated.

asaunier commented 8 years ago

Most of the reported problems should have been addressed by https://github.com/c2corg/v6_ui/pull/628 (may be tested on the demo)

Still remain:

Possibles associations categories not translated

=> see https://github.com/c2corg/v6_ui/issues/629

 maps: + and - icons, up-left corner: tooltips "zoom in" and "zoom out"

A solution to translation those tooltips would be to change the map directive code to do something like:

new ol.control.Zoom({
  zoomInTipLabel: gettextCatalog.getString('Zoom In'),
  zoomOutTipLabel: gettextCatalog.getString('Zoom Out')
})

as in https://github.com/camptocamp/ngeo/blob/0b432ab0d8abeaa9a2f092419633a45d22078cb5/contribs/gmf/src/controllers/abstractmobile.js#L117-L130 or https://github.com/camptocamp/ngeo/blob/f4f745701bddfbac79dc16d39479f72d17c880a3/contribs/gmf/src/controllers/abstractdesktop.js#L91-L109 but that means explicitely redefining the map controls. Not sure it's worth making such changes for those 2 tooltips that are not very complicated to understand. I would recommend to leave them untranslated.

asaunier commented 8 years ago

@shortoland could you test the demo and close the issue if it is fixed?

shortoland commented 8 years ago

@asaunier I agree concerning "zoom in" and "zoom out".

Still have some untranslated strings:

asaunier commented 8 years ago

Thanks @shortoland I think those missing translations will be fixed by https://github.com/c2corg/v6_ui/pull/664 (not merged yet).

asaunier commented 8 years ago

@shortoland The demo has been updated.

shortoland commented 8 years ago

@asaunier OK, still one problem (Possibles associations categories not translated), but I think it now concerns another ticket, so I close this one.

asaunier commented 8 years ago

OK, still one problem (Possibles associations categories not translated), but I think it now concerns another ticket, so I close this one.

Yes I think it's related to https://github.com/c2corg/v6_ui/issues/629