search

c2corg / v6_ui

UI for c2c.org v6
GNU Affero General Public License v3.0
7 stars 12 forks source link

Outing - Block Associated route still display an empty area when closed #966

Closed dribagnac closed 7 years ago

dribagnac commented 7 years ago

When I am displaying an outing, for eg http://www.demov6.camptocamp.org/outings/821396/fr/pointe-de-chalune-par-le-col-de-la-ramaz-depuis-sommand#/&gid=1&pid=4

I want to close the block Associated route, a small DIV is still displayed (div class="associated-documents collapse") screenshot-www demov6 camptocamp org 2016-11-23 11-15-20

ginold commented 7 years ago

probably because .associated-documents has a padding-top, which does not play too well with bootstraps .collapse

brunobesson commented 7 years ago

It's both the padding-bottom: 10px and the border: 1px solid #eee properties. They are defined in https://github.com/c2corg/v6_ui/blob/master/less/viewdetails.less#L325

But don't you think we could remove them? The visuals are OK for me without (it's lighter, I don't like having too many imbricated borders).

asaunier commented 7 years ago

That doesn't look like a critical problem. I have postponed it to 6.1.

brunobesson commented 7 years ago

See PR #1018

The boxes collapse nicely, plus IMHO the design is lighter and more attractive. When the content needs scrollbars, I find it properly integrated too.

stef74 commented 7 years ago

@brunobesson you PR fix this issue ?

brunobesson commented 7 years ago

Yes, it does. You can close the issue.

Le 4 déc. 2016 6:50 PM, "stef74" notifications@github.com a écrit :

@brunobesson https://github.com/brunobesson you PR fix this issue ?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/c2corg/v6_ui/issues/966#issuecomment-264718730, or mute the thread https://github.com/notifications/unsubscribe-auth/ACIWqBJCbdGO4io5SQMaxAJ7Iz0Ll87Tks5rEv1JgaJpZM4K6aX2 .