search

c2lang / c2compiler

the c2 programming language
c2lang.org
Apache License 2.0
704 stars 49 forks source link

Type.cpp missing a few AST descriptions #85

Open lerno opened 5 years ago

lerno commented 5 years ago

Struct, Enum, Function and ModuleType is missing debug descriptions.

I think @bvdberg is best suited to decide what should go into those.

bvdberg commented 5 years ago

What is missing exactly? Is the debug print of the AST incomplete?

lerno commented 5 years ago

In some cases the debug printout has a TODO in it. It’s very unclear to me what’s missing (and probably other contributors would be similarly confused.

I’m on a quest investigating all of the todos so we can get most of them closed as they sometimes come back to haunt you when implementing/fixing something unrelated.

lerno commented 5 years ago

For this, it’s just debug printouts that needs to have their todos resolved.

bvdberg commented 5 years ago

There's a lot of (minor) stuff missing. But we have quite some coverage with unit tests, so that's okey. So any new functionality will also have to be supported by tests.

lerno commented 5 years ago

Can we please not close these unless done? The whole point was to have a list of things that’s needed to do. Unless you just fixed it in a check in. This issue should stay until resolved.

bvdberg commented 5 years ago

Sure, but please don't open an issue for every TODO in the code..

lerno commented 5 years ago

:D I promise. The point of opening this one was that I didn't feel able to resolve it myself. I was unsure what you were planning in terms of extending the debug information. If there was a bit of discussion / docs around the TODO / functionality – or it is actually breaking functionality, then I can just go ahead and fix it.