c2nes / javalang

Pure Python Java parser and tools
MIT License
736 stars 161 forks source link

Handle multiple author tags while parsing javadoc strings. #1

Closed atheriel closed 11 years ago

atheriel commented 11 years ago

I ran into a slight problem with this module while using javasphinx (which depends on it).

According to the Javadocs specification:

You can provide one @author tag, multiple @author tags, or no @author tags.

Currently, javalang will set the author value to the last author tag found. I would consider this a bug, since many java source files contain a list of author tags, and this list would be systematically suppressed by the current parser.

This patch fixes this problem, and allows multiple authors. I can also fix the downstream implementation in javasphinx, if that seems appropriate.

c2nes commented 11 years ago

Good catch and thanks for the fix. I would gladly accept a patch to tie this back into javashpinx as well. Sorry for being slow to respond.