c2siorg / Codelabz

Codelabz
Apache License 2.0
11 stars 51 forks source link

Remove Header from 404 Page #86

Closed Hemu21 closed 5 months ago

Hemu21 commented 6 months ago

Describe the bug

404 page does not contain any header or any footer. But You can find the header in 404 page. 404 page can contain a button that redirect to the home page. This is the bug present in 404 page.

To Reproduce Steps to reproduce the behavior:

  1. Go to any url location not present in the website.
  2. example url "http://localhost:5173/werty"
  3. You can see the 404 page. It contains the header.
  4. As shown in below Image

create_issue

Expected behavior

  1. When you go to any url location not present in the website.
  2. example url "http://localhost:5173/werty"
  3. You can see the 404 page. It does not contain the header.
  4. As shown in below Image

404_expected

github-actions[bot] commented 6 months ago

Hello 👋🏻 @Hemu21! Thankyou for creating an issue!

rohitPandey469 commented 6 months ago

Give it a fixed width and height, make it go exact at the center. And, for the time being, the access control requirements will stay same, so decentralized check in the routes file would be ok I think i.e. UserIsAllowed CheckSSS in one file. What are your thoughts about this @Hemu21 ??

Hemu21 commented 6 months ago

@rohitPandey469 Ok, I will make it center.

Hemu21 commented 6 months ago

@rohitPandey469 Now Fixed in the #87 Thank you for the suggestion.

github-actions[bot] commented 5 months ago

This issue is stale because it has been open for 30 days with no activity.

github-actions[bot] commented 5 months ago

This issue was closed because it has been inactive for 14 days since being marked as stale.