Closed hardik1408 closed 5 months ago
@CoToYo can you please review this?
@CoToYo can you please review this?
Sure. Will do.
@CoToYo Any comments for the same? Do I need to make any changes?
@CoToYo Any comments for the same? Do I need to make any changes?
Hi,
I added a comment on services/NewsService.py
, please check it out.
The code update looks good to me! However, since this is a kind of fundamental change, we would like to hold your PR until the contributor of our project for GSOC 2024 is selected. Hope you can understand.
Also, we welcome you to write a proposal and apply our project on GSOC website: https://summerofcode.withgoogle.com/programs/2024/organizations/c2si Notice: April 02 is the deadline for proposal submission.
@CoToYo Any comments for the same? Do I need to make any changes?
Hi, I added a comment on
services/NewsService.py
, please check it out.The code update looks good to me! However, since this is a kind of fundamental change, we would like to hold your PR until the contributor of our project for GSOC 2024 is selected. Hope you can understand.
Hey @CoToYo , Thank you for your reply. I cannot see your comment in the code. Can you please direct me to it? Also my proposal is ready for this project. Can I share it with you so that you can review it once?
@CoToYo Any comments for the same? Do I need to make any changes?
Hi, I added a comment on
services/NewsService.py
, please check it out. The code update looks good to me! However, since this is a kind of fundamental change, we would like to hold your PR until the contributor of our project for GSOC 2024 is selected. Hope you can understand.Hey @CoToYo , Thank you for your reply. I cannot see your comment in the code. Can you please direct me to it? Also my proposal is ready for this project. Can I share it with you so that you can review it once?
Can you see it now? (We will start to review candidates' proposals after April 2)
Can you see it now
Yeah, I can see now. Thanks!
Description
requirements.txt
file has also been changed in order to downloadhuggingface_hub
to provide access to LLMs on huggingface..env
file has also been created to store the huggingface token.Related Issue
This change directly implements issue #16 .
Motivation and Context
This change was required because it is not feasable to use openai credits. Similar work can be done by open LLMs without any extra cost.
How Has This Been Tested?
I have directly checked and run the endpoint in a seperate colab file. Then I directly implemented it in the
NewsService.py
file.Screenshots (if appropriate):
Sample data I used to check
Output received
Types of changes
Checklist:
[x] My code follows the code style of this project.
[x] My change requires a change to the documentation.
[x] I have updated the documentation accordingly.
[x] I have read the CONTRIBUTING document.
[x] I have added tests to cover my changes.
[x] All new and existing tests passed.
Future Scope
If given the green light, I can implement this thing for other functions also. Also, we can test it with different LLMs available on huggingface before deciding which is the best, or we can add a functionality where the user can choose their own LLM.