c3-time-domain / SeeChange

A time-domain data reduction pipeline (e.g., for handling images->lightcurves) for surveys like DECam and LS4
BSD 3-Clause "New" or "Revised" License
0 stars 4 forks source link

Roundup of issues from recent PRs #190

Closed guynir42 closed 5 months ago

guynir42 commented 5 months ago

Rounding up a bunch of semi-related issues into a single PR, to cleanup a bunch of open issues we collected when working on a set of recent PRs.

guynir42 commented 5 months ago

In addition, and I don't know why this happened, I started to make some minor adjustments to how we merge things in the data store. That caused a whole bunch of bugs that I have been running after for three days, touching half of our code.

guynir42 commented 5 months ago

@rknop There are still a couple of test failures, related to object cleanup (not the actual logic of the tests). If you have time to review this, you can start, and I will fix the remaining minor issues tomorrow morning.

guynir42 commented 5 months ago

@rknop I've addressed all comments. Please have another look and see if it is ok to merge (use the "see changes since last review" to save time). Thanks!