c3-time-domain / SeeChange

A time-domain data reduction pipeline (e.g., for handling images->lightcurves) for surveys like DECam and LS4
BSD 3-Clause "New" or "Revised" License
0 stars 4 forks source link

Archive Cleanup #191

Closed guynir42 closed 4 months ago

guynir42 commented 5 months ago

This PR makes two different setups for communicating with the archive during tests.

In the local config method, we use local_read_dir and local_write_dir to define direct folder access to the archive, as you'd do when you were using a local (or mounted) folder to contain the archive storage.

In the dockerized config method, we use the archive as a server, where archive_url: http://archive:8080/ is used to communicate with the archive, as you would when, e.g., launching the pipeline on a cloud server or on NERSC. In this case we will re-introduce the environmental variable SEECHANGE_TEST_ARCHIVE_DIR to the docker compose file, so that tests can go to the actual storage and see what is going on in the archive when stuff gets added/deleted there.

In addition, I would also like to verify that

guynir42 commented 5 months ago

@rknop There's a test failure that is related to an issue that I've solved in PR #190 and everything else is passing.

guynir42 commented 4 months ago

@rknop These files used to exist on NERSC. They were also hard-coded but that didn't help.

Here's the folder: https://portal.nersc.gov/cfs/m2218/decat/decat/templatecache/

It contains several other files, but the specific one we used as a reference for DECam is gone.

Please check if you can re-upload it there. The files are in the tens-of-megabytes and I don't see a reason to add them to the repo when we are already downloading so many other things on the fly.