search

c3-time-domain / SeeChange

A time-domain data reduction pipeline (e.g., for handling images->lightcurves) for surveys like DECam and LS4
BSD 3-Clause "New" or "Revised" License
0 stars 4 forks source link

Cutouts Model #206

Closed guynir42 closed 3 months ago

guynir42 commented 4 months ago

Create the actual code that saves and loads cutouts into HDF5 files.

guynir42 commented 3 months ago

I agree that this is a good idea.

But since I'm half way done with Measurements, I don't think this is the best time to make the change.

I suggest I open an issue and start working on it after we are done with Measurements. I think I will also need some time to figure out the interfaces (e.g., would the datastore still hold a list of Cutouts objects or just the CutoutsFile? Would the CutoutsFile know all the Cutouts pointing to it?).

guynir42 commented 3 months ago

If you agree to defer please approve this PR so I can merge it into Measurements. Thanks!

rknop commented 3 months ago

Sounds good, I dont't think it will be too hard to change this later. (Have you made an issue already?)