c3-time-domain / SeeChange

A time-domain data reduction pipeline (e.g., for handling images->lightcurves) for surveys like DECam and LS4
BSD 3-Clause "New" or "Revised" License
0 stars 4 forks source link

Coordinates for measurements #234

Closed guynir42 closed 1 month ago

guynir42 commented 3 months ago

The Ra/dec for a cutouts object represents the coordinates of the middle of the cutout. But a measurements object will already have some additional offsets given by the measured centroid. This could include a sub-pixel shift (or more than 1 pixel shift) that needs to be accounted for when setting the coordinates. These are also the coordinates that get fed into the Object RA/dec.

I'm not even sure anything is propagated into those fields right now. We should explicitly test that the Measurements get an RA/dec and that it is different than the Cutouts pair, and that the derived coordinates get calculated properly (e.g., ecliptic).

guynir42 commented 3 months ago

It may also be a good place to put uncertainties on the measurements.