c3-time-domain / SeeChange

A time-domain data reduction pipeline (e.g., for handling images->lightcurves) for surveys like DECam and LS4
BSD 3-Clause "New" or "Revised" License
0 stars 4 forks source link

Make sure that warped image database entries are created correctly #240

Open rknop opened 6 months ago

rknop commented 6 months ago

Look at ImageAligner.image_source_warped_to_target ; there are some comments there.

Right now the Image database entry for the warped image is made by copying the source image's entry, but then pasting in the ra/dec and four corners fields from the target entry. This is right as far as it goes, but we need to make sure that everything else is right too.

[[ Perhaps out of scope for this issue: PSFs should be remeasured (if they aren't already). The spatial variation of the PSF from the source image will now be wrong, because pixels have shifted. the PSF may also be slightly modified because of the blurring effect of resampling pixels. ]] ← this already happens in ImageAligner._align_swarp

guynir42 commented 3 months ago

@rknop It looks to me like we can close this issue... what do you think?