c3-time-domain / SeeChange

A time-domain data reduction pipeline (e.g., for handling images->lightcurves) for surveys like DECam and LS4
BSD 3-Clause "New" or "Revised" License
0 stars 4 forks source link

catalog_tools.fetch_gaia_dr3_exerpt fails if magrange isn't given #252

Open rknop opened 2 months ago

rknop commented 2 months ago

This code:

            if magrange is not None:
                minmag = maxmag - magrange
                q = ( q.filter( CatalogExcerpt.minmag >= minmag-0.1 )
                      .filter( CatalogExcerpt.minmag <= minmag+0.1 ) )

needs an else.

And also a test that makes sure that things work if magrange is None....