search

c3-time-domain / SeeChange

A time-domain data reduction pipeline (e.g., for handling images->lightcurves) for surveys like DECam and LS4
BSD 3-Clause "New" or "Revised" License
0 stars 4 forks source link

Add sigma clipping for background estimation #254

Closed dryczanowski closed 1 month ago

dryczanowski commented 2 months ago

Change background estimation to use hard edge annulus with sigma clipping. Add relevant tests.

dryczanowski commented 2 months ago

Flaky test fails sometimes on test_measuring, to do with the background error. Sometimes fails on [10], sometimes [11], sometimes passes. Unsure if the variance should also be sigma clipped which might fix the issue but unsure if this actually makes sense.

guynir42 commented 1 month ago

You have conflicts. Do git fetch upstream and the git merge upstream/main, resolve the conflicts manually and commit. Then if tests are passing you can squash and merge.