c3-time-domain / SeeChange

A time-domain data reduction pipeline (e.g., for handling images->lightcurves) for surveys like DECam and LS4
BSD 3-Clause "New" or "Revised" License
0 stars 4 forks source link

Update tests for alerts with previous detections #365

Open rknop opened 2 weeks ago

rknop commented 2 weeks ago

In tests/pipeline/test_alerting.py , the test test_alerts_with_previous is currently marked to be skipped. Reason: I found images in the DECat pipeline that used the reference were already using in tests (so I didn't have to rewrite a whole bunch of other tests if we changed our test DECam images) that had detections. However, SeeChange is not finding them. It's possible that the detections were not real (though I'm skeptical; they look like legitimate quasars) and the DECat pipeline detected them where it shouldn't, and zogy is properly missing it. It's also possible that zogy is missing real things.

Once more investigation into what we're catching in subtraction is done, come back and revisit this test.