c33s / StaticPageContentBundle

provide static pages in symfony
5 stars 1 forks source link

decide how to to support empty baseTemplate #30

Closed ghost closed 10 years ago

ghost commented 10 years ago

There are two easy ways to fix this todo:

TODO: only extend base template if base template string is not empty

we could do something like this:

{% extends baseTemplate ? baseTemplate : "empty.html.twig" %}

OR

{% extends [baseTemplate, 'empty.html.twig'] %}

as per this http://twig.sensiolabs.org/doc/tags/extends.html#dynamic-inheritance

the 2nd might be more exciting if we want multiple fallbacks

c33s commented 10 years ago

would be ok for me

vworldat commented 10 years ago

:+1:

ghost commented 10 years ago

fixed this one too in #35