search

c33s / StaticPageContentBundle

provide static pages in symfony
5 stars 1 forks source link

require symfony 2.3 lts and switch to composer #8

Closed ghost closed 10 years ago

ghost commented 10 years ago

I bumped the min php version too, since it matches symfony's min php version

c33s commented 10 years ago

do you have a special reason, that you want to require symfony 2.3?

i'm not a big fan of setting requirements that are not actually needed, because they might break things for others or prevent someone from using an older version of symfony (the person might have a reason to do so).

as soon as there is a technical requirement, i will of course accept this pull request.

c33s commented 10 years ago

do you require it for https://github.com/c33s/StaticPageContentBundle/issues/10?

ghost commented 10 years ago

Probably. I don't have any old symfony projects to test on that are pre lts to guarantee that i won't break it for those. I can only guarantee for lts.

In any case I don't think it's a good idea to depend on versions that are totally end of life. Those versions likely have serious security defects in them that will never be fixed now.

ghost commented 10 years ago

as far as the minimum php version. that hasn't changed in symfony at all. so there is no reason not to accept that change as symfony (of any version) will require 5.3.3 anyways.

ghost commented 10 years ago

please merge this!

ghost commented 10 years ago

actually ignore that.. i'm gonna submit that change as part of the next patchset.