search

c3aidti / smoke

Gordon Group space
MIT License
0 stars 0 forks source link

Batch Job/ Merge Question #28

Closed vasanchez16 closed 1 year ago

vasanchez16 commented 1 year ago

Hey @babreu-ncsa,

I was experimenting with the batch job workflow for the smokeppe data set and Jupyter gave me an error indicating that it could not find the necessary function/types for this (ex. smokePPEGaussianMLTrainingJobOptions ). Based on the error, it gave me I tried to merge the file folder for these functions (smokePPEGaussianML) into dev/smokeApp/rc1 so jupyter could see it but I ran into trouble doing this as I am still learning version control. Could you help me with this merge or let me know if this is not necessary?

This is the error I was getting in the notebooks: Type 'smokePPEGaussianMLTrainingJobOptions' not found for tenant 'smokeApp' tag 'devsmokeApprc1'

This is the note book I was using: https://devsmokeapprc1-smokeapp.devrc01.c3aids.cloud/jupyter/notebooks/sandbox/Batch%20Trials/Batch%20Trial%201.ipynb

Thank you in advance, Victor

babreu-ncsa commented 1 year ago

Hi @vasanchez16, thanks for reporting it! I found a couple of things that need to be adjusted before this works. Do you have time for a zoom call today or tomorrow?

vasanchez16 commented 1 year ago

Hey @babreu-ncsa,

I have all my classes today but I can meet anytime tomorrow before 2PM EST or after 4PM EST. Let me know what works for you.

babreu-ncsa commented 1 year ago

Hi @vasanchez16, sorry for the delay in getting back to you about the meeting. There were two small issues that I fixed; it should be working now:

1) Types need to start with a capital letter. I renamed all files and types. 2) The code was never provisioned to the tag, so the c3 server would not know about these new types. Provisioning sends the code to the remote c3 server and makes it render the new version, effectively implementing your new definitions. To do that, you must have a pull request open from the development branch (in this case, smoke-dev) into the target tag branch (in this case, dev/smokeApp/rc1). PR #29 is one example of that. Having the PR open will trigger the provisioning workflow when you push commits from your local machine into the remote (GitHub-based) smoke-dev using git push.

Let me know if you have any questions.

vasanchez16 commented 1 year ago

Hi @babreu-ncsa,

Great, thanks so much! I'll get back to you if I have any questions.