search

c3js / c3

:bar_chart: A D3-based reusable chart library
http://c3js.org
MIT License
9.34k stars 1.39k forks source link

fixed isWithinBar() crash when there were less than 2 items in pathSe… #2652

Closed panthony closed 5 years ago

panthony commented 5 years ago

Rebased version of #1550

I'm using c3js within a webapp based on Ember and it can happen that charts are drawn & destroyed even before they finish loading.

When navigating I can often have the following error happening:

Capture d’écran 2019-07-26 à 11 16 47

codecov-io commented 5 years ago

Codecov Report

Merging #2652 into master will decrease coverage by 0.01%. The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2652      +/-   ##
==========================================
- Coverage   80.14%   80.13%   -0.02%     
==========================================
  Files          57       57              
  Lines        4518     4520       +2     
==========================================
+ Hits         3621     3622       +1     
- Misses        897      898       +1
Impacted Files Coverage Δ
src/shape.bar.js 98.64% <50%> (-1.36%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4643f4f...033a2e2. Read the comment docs.

codecov-io commented 5 years ago

Codecov Report

Merging #2652 into master will decrease coverage by 0.01%. The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2652      +/-   ##
==========================================
- Coverage   80.14%   80.13%   -0.02%     
==========================================
  Files          57       57              
  Lines        4518     4520       +2     
==========================================
+ Hits         3621     3622       +1     
- Misses        897      898       +1
Impacted Files Coverage Δ
src/shape.bar.js 98.64% <50%> (-1.36%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4643f4f...033a2e2. Read the comment docs.

codecov-io commented 5 years ago

Codecov Report

Merging #2652 into master will decrease coverage by 0.01%. The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2652      +/-   ##
==========================================
- Coverage   80.14%   80.13%   -0.02%     
==========================================
  Files          57       57              
  Lines        4518     4520       +2     
==========================================
+ Hits         3621     3622       +1     
- Misses        897      898       +1
Impacted Files Coverage Δ
src/shape.bar.js 98.64% <50%> (-1.36%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4643f4f...033a2e2. Read the comment docs.

codecov-io commented 5 years ago

Codecov Report

Merging #2652 into master will decrease coverage by 0.01%. The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2652      +/-   ##
==========================================
- Coverage   80.14%   80.13%   -0.02%     
==========================================
  Files          57       57              
  Lines        4518     4520       +2     
==========================================
+ Hits         3621     3622       +1     
- Misses        897      898       +1
Impacted Files Coverage Δ
src/shape.bar.js 98.64% <50%> (-1.36%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4643f4f...033a2e2. Read the comment docs.