c3js / c3

:bar_chart: A D3-based reusable chart library
http://c3js.org
MIT License
9.35k stars 1.39k forks source link

replace getBoundingClientRect by getBBox where appropriate #2672

Closed panthony closed 5 years ago

panthony commented 5 years ago

Note that SVGRect, returned by getBBox, only contains {x,y,width,height} and not {top,left}.

It closes #2614

codecov-io commented 5 years ago

Codecov Report

Merging #2672 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2672   +/-   ##
=======================================
  Coverage   80.13%   80.13%           
=======================================
  Files          57       57           
  Lines        4520     4520           
=======================================
  Hits         3622     3622           
  Misses        898      898
Impacted Files Coverage Δ
src/shape.bar.js 98.64% <100%> (ø) :arrow_up:
src/util.js 100% <100%> (ø) :arrow_up:
src/axis-internal.js 94.88% <100%> (ø) :arrow_up:
src/text.js 98.68% <100%> (ø) :arrow_up:
src/axis.js 97.55% <100%> (ø) :arrow_up:
src/data.js 84.52% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a4c971c...fbf8319. Read the comment docs.

codecov-io commented 5 years ago

Codecov Report

Merging #2672 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2672   +/-   ##
=======================================
  Coverage   80.13%   80.13%           
=======================================
  Files          57       57           
  Lines        4520     4520           
=======================================
  Hits         3622     3622           
  Misses        898      898
Impacted Files Coverage Δ
src/shape.bar.js 98.64% <100%> (ø) :arrow_up:
src/util.js 100% <100%> (ø) :arrow_up:
src/axis-internal.js 94.88% <100%> (ø) :arrow_up:
src/text.js 98.68% <100%> (ø) :arrow_up:
src/axis.js 97.55% <100%> (ø) :arrow_up:
src/data.js 84.52% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a4c971c...fbf8319. Read the comment docs.