Closed panthony closed 4 years ago
Merging #2674 into master will increase coverage by
0.01%
. The diff coverage is96.87%
.
@@ Coverage Diff @@
## master #2674 +/- ##
=========================================
+ Coverage 80.29% 80.3% +0.01%
=========================================
Files 59 60 +1
Lines 4537 4565 +28
=========================================
+ Hits 3643 3666 +23
- Misses 894 899 +5
Impacted Files | Coverage Δ | |
---|---|---|
src/core.js | 89.95% <100%> (-0.16%) |
:arrow_down: |
src/data.js | 84.7% <100%> (+0.18%) |
:arrow_up: |
src/subchart.js | 87.5% <100%> (-1.39%) |
:arrow_down: |
src/api.subchart.js | 91.66% <91.66%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update bdf12d1...7a3d6dd. Read the comment docs.
@kt3k I just don't get it, I installed from scratch RVM, bundler, etc.. from the 0.7.3
tag and the documentation site served by watch:docs
does not work.
I have a wonderful NameError: uninitialized constant #<Class:0x00007fdfd8214c78>::EXPR_BEGEXPR_BEGEXPR_BEGEXPR_BEGEXPR_CMDARGEXPR_DOTEXPR_ARGEXPR_BEG
error located here:
%a( href="##{ id.gsub(/\./, '-') }")< #{ id.gsub(/(api|class)\./, '') }
I played around and the issue is with %a()
.. maybe it misses id
? Result of a breaking change due to an unwanted update ?
I really have no clue I have 0 knowledge of the stack used to generate the doc.
@panthony Which ruby version do you use? You need ruby 2.4.4 for building the current document site (I think it can't be built with ruby 2.5 or above).
@kt3k I'll check that on monday, I do not have my laptop with me this week-end but I'll likely have the most recent version of ruby.
Good to know I should not have a version too recent, thanks :)
edit:
Annnnnd it was clearly stated in CONTRIBUTING.md
:
Note: Currently the site doesn't build with ruby 2.5.x, so you need ruby 2.4.4 or below. ([rbenv][] is useful for switching between ruby versions.)
Maybe one day I'll learn to fully read something 🥇
This PR does several things: