search

c3js / c3

:bar_chart: A D3-based reusable chart library
http://c3js.org
MIT License
9.34k stars 1.39k forks source link

Fix: tween callbacks run after chart is destroyed. #2681

Closed cythrawll closed 5 years ago

cythrawll commented 5 years ago

2213

previous PR was abandoned, but we still see this error quite a bit, would like to see this cleaned up.

codecov-io commented 5 years ago

Codecov Report

Merging #2681 into master will decrease coverage by 0.01%. The diff coverage is 50%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2681      +/-   ##
==========================================
- Coverage   80.58%   80.57%   -0.02%     
==========================================
  Files          59       59              
  Lines        4631     4633       +2     
==========================================
+ Hits         3732     3733       +1     
- Misses        899      900       +1
Impacted Files Coverage Δ
src/arc.js 74.4% <50%> (-0.17%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1d496d3...42137db. Read the comment docs.

codecov-io commented 5 years ago

Codecov Report

Merging #2681 into master will increase coverage by 0.44%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2681      +/-   ##
==========================================
+ Coverage   80.58%   81.02%   +0.44%     
==========================================
  Files          59       59              
  Lines        4631     4633       +2     
==========================================
+ Hits         3732     3754      +22     
+ Misses        899      879      -20
Impacted Files Coverage Δ
src/arc.js 75.08% <100%> (+0.51%) :arrow_up:
src/core.js 90.74% <0%> (+0.63%) :arrow_up:
src/data.load.js 64% <0%> (+6%) :arrow_up:
src/api.chart.js 65.38% <0%> (+46.15%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1d496d3...1d9a973. Read the comment docs.

panthony commented 5 years ago

@cythrawll Looks good! Thanks!