codecov-io
commented
5 years ago Codecov Report
Merging #2686 into master will decrease coverage by
<.01%. The diff coverage is75%.
@@ Coverage Diff @@
## master #2686 +/- ##
==========================================
- Coverage 81.02% 81.01% -0.01%
==========================================
Files 59 59
Lines 4633 4636 +3
==========================================
+ Hits 3754 3756 +2
- Misses 879 880 +1| Impacted Files | Coverage Δ | |
|---|---|---|
| src/class-utils.js | 95.83% <75%> (-1.27%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 4cb80e7...513cdaa. Read the comment docs.
This PR closes #2353
In the end I did not introduce a new dependency.
I though about #2407 where size really matters and I did not feel like adding this polyfill for everyone.
This PR uses
CSS.escapeor fallback to previous method if not available, meaning the issue would still occurs for old browsers (ex: IE) but I think we'd better off explaining this and leaving the responsability to the user to embed a polyfill if needed.