c3js / c3

:bar_chart: A D3-based reusable chart library
http://c3js.org
MIT License
9.34k stars 1.39k forks source link

more cache hits for getMaxTickWidth #2687

Open panthony opened 5 years ago

panthony commented 5 years ago

This PR:

This way we have more cache hits and the cache is dropped each time we want to redraw the chart (thinking of resize etc.) which should be, hopefully, sufficient.

codecov-io commented 5 years ago

Codecov Report

Merging #2687 into master will increase coverage by 0.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2687      +/-   ##
==========================================
+ Coverage   81.02%   81.03%   +0.01%     
==========================================
  Files          59       59              
  Lines        4633     4636       +3     
==========================================
+ Hits         3754     3757       +3     
  Misses        879      879
Impacted Files Coverage Δ
src/core.js 90.74% <100%> (ø) :arrow_up:
src/size.js 93.75% <100%> (ø) :arrow_up:
src/axis.js 97.6% <100%> (+0.02%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4cb80e7...b5183d6. Read the comment docs.

codecov-io commented 5 years ago

Codecov Report

Merging #2687 into master will increase coverage by 0.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2687      +/-   ##
==========================================
+ Coverage   81.02%   81.04%   +0.01%     
==========================================
  Files          59       59              
  Lines        4633     4637       +4     
==========================================
+ Hits         3754     3758       +4     
  Misses        879      879
Impacted Files Coverage Δ
src/core.js 90.76% <100%> (+0.01%) :arrow_up:
src/size.js 93.75% <100%> (ø) :arrow_up:
src/axis.js 97.6% <100%> (+0.02%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4163be5...0325fb6. Read the comment docs.