search

c3js / c3

:bar_chart: A D3-based reusable chart library
http://c3js.org
MIT License
9.34k stars 1.39k forks source link

only set shape-rendering for standard graph type #2691

Closed panthony closed 5 years ago

panthony commented 5 years ago

The "shape-rendering" was introduced with the stanford graph type but it makes the scatter appears really .... not sharp.

This PR make it so that the crispEdges is only set for stanford.

Closes #2689

codecov-io commented 5 years ago

Codecov Report

Merging #2691 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2691   +/-   ##
=======================================
  Coverage   81.02%   81.02%           
=======================================
  Files          59       59           
  Lines        4633     4633           
=======================================
  Hits         3754     3754           
  Misses        879      879
Impacted Files Coverage Δ
src/shape.line.js 71.75% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4cb80e7...da4978a. Read the comment docs.

codecov-io commented 5 years ago

Codecov Report

Merging #2691 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2691   +/-   ##
=======================================
  Coverage   81.02%   81.02%           
=======================================
  Files          59       59           
  Lines        4633     4633           
=======================================
  Hits         3754     3754           
  Misses        879      879
Impacted Files Coverage Δ
src/shape.line.js 71.75% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4cb80e7...da4978a. Read the comment docs.