search

c3js / c3

:bar_chart: A D3-based reusable chart library
http://c3js.org
MIT License
9.35k stars 1.39k forks source link

Style empty points in line charts via CSS #2693

Closed panthony closed 5 years ago

panthony commented 5 years ago

An up to date version of #1992

I'll merge this in my fork because it looks neat, I'll leave you to decide if you want this in the main repository.

The culprit is that currentColor is not supported by IE8, in my case I do not care, maybe some will.

Although I'm not sure how well IE8 is supported at the moment (maybe not at all.).

codecov-io commented 5 years ago

Codecov Report

Merging #2693 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2693   +/-   ##
=======================================
  Coverage   81.02%   81.02%           
=======================================
  Files          59       59           
  Lines        4633     4633           
=======================================
  Hits         3754     3754           
  Misses        879      879
Impacted Files Coverage Δ
src/shape.line.js 71.75% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4163be5...3c07c17. Read the comment docs.

codecov-io commented 5 years ago

Codecov Report

Merging #2693 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2693   +/-   ##
=======================================
  Coverage   81.02%   81.02%           
=======================================
  Files          59       59           
  Lines        4633     4633           
=======================================
  Hits         3754     3754           
  Misses        879      879
Impacted Files Coverage Δ
src/shape.line.js 71.75% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4163be5...3c07c17. Read the comment docs.