c3js / c3

:bar_chart: A D3-based reusable chart library
http://c3js.org
MIT License
9.33k stars 1.39k forks source link

Improve normalized stack bar performance #2699

Open panthony opened 4 years ago

panthony commented 4 years ago

I had a huge performance regression for normalized stack bar when I have a thousand bar and ~10 series.

It makes the browser hang for a while, stuck in 'filterTargetsToShow' mainly.

When I investigated I found that:

codecov-io commented 4 years ago

Codecov Report

Merging #2699 into master will decrease coverage by 0.04%. The diff coverage is 90.32%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2699      +/-   ##
==========================================
- Coverage   82.68%   82.64%   -0.05%     
==========================================
  Files          59       59              
  Lines        4718     4724       +6     
==========================================
+ Hits         3901     3904       +3     
- Misses        817      820       +3
Impacted Files Coverage Δ
src/shape.js 95.52% <100%> (+0.13%) :arrow_up:
src/data.js 88.34% <83.33%> (-0.79%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 93dcd65...115cb29. Read the comment docs.