search

c3js / c3

:bar_chart: A D3-based reusable chart library
http://c3js.org
MIT License
9.33k stars 1.39k forks source link

correct initial visibility of hidden bars #2702

Closed panthony closed 4 years ago

panthony commented 4 years ago

When using 'data_hide' option, the bars are not taken into account when computing offsets and so on but they still have 'opacity:1'.

There is another issue that I have no time to really dig into is that the order of targets (given to the legend) may changes when you toggle back the initially hidden series, visible with the c3 chart interaction bar chart tooltip_grouped=true expands all bars of currently hovered category test.

Closes #2685

codecov-io commented 4 years ago

Codecov Report

Merging #2702 into master will decrease coverage by 0.01%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2702      +/-   ##
==========================================
- Coverage   82.68%   82.66%   -0.02%     
==========================================
  Files          59       59              
  Lines        4718     4720       +2     
==========================================
+ Hits         3901     3902       +1     
- Misses        817      818       +1
Impacted Files Coverage Δ
src/shape.bar.js 100% <100%> (ø) :arrow_up:
src/core.js 90.74% <0%> (-0.16%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 93dcd65...f615ea3. Read the comment docs.