c3js / c3

:bar_chart: A D3-based reusable chart library
http://c3js.org
MIT License
9.33k stars 1.39k forks source link

Rebasing region label work from PR 1853 #2703

Closed dunderpate closed 4 years ago

dunderpate commented 4 years ago

Hi @panthony, here's an updated patch for PR #1853.

The tests failed due to something seemingly unrelated (legend padding), and the same failure was also occurring on master. Apart from that, everything else seemed to work fine. Feel free to let me know if there's anything amiss and I'll be happy to fix it.

Thanks @panthony!

codecov-io commented 4 years ago

Codecov Report

Merging #2703 into master will increase coverage by 0.04%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2703      +/-   ##
==========================================
+ Coverage   82.68%   82.72%   +0.04%     
==========================================
  Files          59       59              
  Lines        4718     4735      +17     
==========================================
+ Hits         3901     3917      +16     
- Misses        817      818       +1
Impacted Files Coverage Δ
src/region.js 91.8% <100%> (+3.16%) :arrow_up:
src/core.js 90.74% <0%> (-0.16%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 93dcd65...a75f22c. Read the comment docs.

panthony commented 4 years ago

@dunderpate Ideally we should document those new options in the reference.

And if this could be greenlighted by @kt3k that would be awesome 👍

dunderpate commented 4 years ago

@panthony, thanks for the review. I'll take a stab at updating the reference documentation.

dunderpate commented 4 years ago

Right on, ready for a review of the documentation when you have time @panthony. Thanks!

panthony commented 4 years ago

@dunderpate Looks good! Thanks!

dunderpate commented 4 years ago

Right on, thanks @panthony!