search

c3js / c3

:bar_chart: A D3-based reusable chart library
http://c3js.org
MIT License
9.33k stars 1.39k forks source link

2289 - Add example of arc chart with fullCircle: true #2714

Closed ignoreintuition closed 4 years ago

ignoreintuition commented 4 years ago
codecov-io commented 4 years ago

Codecov Report

Merging #2714 into master will decrease coverage by 0.02%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2714      +/-   ##
==========================================
- Coverage   82.85%   82.83%   -0.03%     
==========================================
  Files          59       59              
  Lines        4748     4748              
==========================================
- Hits         3934     3933       -1     
- Misses        814      815       +1
Impacted Files Coverage Δ
src/core.js 90.74% <0%> (-0.16%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6d5f7e8...d185a50. Read the comment docs.

kt3k commented 4 years ago

Thank you for the contribution, but it looks like you forgot adding samples/chart_arc.html to your commit.

ignoreintuition commented 4 years ago

Yikes. Sorry about that. Please check the latest PR which includes the additional file. Also, please note, there is an issue with the fullCircle and with labels. It appears to overlay the gauge on top of the labels. Let me know if you want me to submit an issue and I can work it.