search

c3js / c3

:bar_chart: A D3-based reusable chart library
http://c3js.org
MIT License
9.34k stars 1.39k forks source link

Fix esm support #2748

Closed kt3k closed 4 years ago

kt3k commented 4 years ago

This PR tries to fix https://github.com/c3js/c3/issues/2747

rollup users are still able to do import c3 from 'c3/c3.esm'

codecov-io commented 4 years ago

Codecov Report

Merging #2748 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2748   +/-   ##
======================================
  Coverage    82.9%   82.9%           
======================================
  Files          60      60           
  Lines        4791    4791           
======================================
  Hits         3972    3972           
  Misses        819     819

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1c3fcec...bd95e39. Read the comment docs.

kt3k commented 4 years ago

Probably what we should do is export { generate, version, chart } instead of export default c3 in src/index.js. I'll update this PR soon.