c3js / c3

:bar_chart: A D3-based reusable chart library
http://c3js.org
MIT License
9.34k stars 1.39k forks source link

refactor: use prettier, switch to 2 indent, no-semi #2766

Closed kt3k closed 4 years ago

kt3k commented 4 years ago

This PR introduce prettier formatter and switches from 4 space indent to 2 space indent, and also switches from semicolon style to no-semicolon style.

(After this change I will remove jshint and introduces eslint instead.)

closes #2763

codecov-io commented 4 years ago

Codecov Report

Merging #2766 into master will decrease coverage by 0.88%. The diff coverage is 49.13%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2766      +/-   ##
==========================================
- Coverage   82.91%   82.03%   -0.89%     
==========================================
  Files          60       60              
  Lines        4793     5159     +366     
==========================================
+ Hits         3974     4232     +258     
- Misses        819      927     +108
Impacted Files Coverage Δ
src/arc.js 76.14% <ø> (+1.06%) :arrow_up:
src/util.js 98.52% <ø> (+0.02%) :arrow_up:
src/zoom.js 70% <ø> (-0.13%) :arrow_down:
src/stanford.js 93.5% <ø> (+0.08%) :arrow_up:
src/grid.js 74.34% <ø> (-0.47%) :arrow_down:
src/colorscale.js 82.05% <ø> (ø) :arrow_up:
src/config.js 95.83% <ø> (ø) :arrow_up:
src/tooltip.js 81.45% <ø> (-0.67%) :arrow_down:
src/data.load.js 60.37% <ø> (-3.63%) :arrow_down:
src/subchart.js 84.76% <ø> (-2.74%) :arrow_down:
... and 86 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6749eb6...6a10d56. Read the comment docs.

kt3k commented 4 years ago

@masayuki0812 Please take a look if you have time.

kt3k commented 4 years ago

@masayuki0812 I believe this is a sensible change and this style conforms better to the modern trends of javascript ecosystem. Please let me know if you have a different opinion.