search

c3sr / pangolin

6 stars 0 forks source link

pangolin::Vector move assignment should destruct elements in moved-to container #21

Closed cwpearson closed 5 years ago

cwpearson commented 5 years ago

https://github.com/c3sr/pangolin/blob/7c75e5c46e1ae863bd6c77887e23f9bb610bf85a/include/pangolin/dense/vector-impl.hu#L62

cwpearson commented 5 years ago

Fixed in 90e7c21e34abb97513cbcb8ae2144de4c74e2516

Instead of worrying about all this, we looked back into our notes and decided to implement copy-assignment and move-assignment with the swap idiom.