search

c3sr / pangolin

6 stars 0 forks source link

COO num_nodes does not return the number of nodes #32

Closed cwpearson closed 5 years ago

cwpearson commented 5 years ago

https://github.com/c3sr/pangolin/blob/698b3454054c7d8446ce90067463e2839e414e5e/include/pangolin/sparse/coo-impl.hpp#L28-L43

It skips some empty source rows sometimes. Let's just make this return num_rows()?

ZaidQureshi commented 5 years ago

Solved with pull request.