search

c4-project / c4t

Runs concurrent C compiler tests
MIT License
1 stars 0 forks source link

Dashboard once again doesn't actually terminate #50

Open MattWindsor91 opened 4 years ago

MattWindsor91 commented 4 years ago

Comme d'habitude.

I figure this is a context that isn't looking at whether it's been cancelled... again. Sigh.

MattWindsor91 commented 4 years ago

I wonder if part of this is because of the shonky re-use of a single channel between multiple senders occasionally in the logging mechanism. When I was making the observer logic for the coverage testbed generator, I noticed there was a similar issue whereby a) channels were blocking trying to send observations to the observer thread, and b) there was no way to close those channels because they were all copies of the same single channel.

It might be worth writing a type-unsafe, but decent abstraction over this.

MattWindsor91 commented 3 years ago

I haven't observed this for a while, so maybe the new observer logic has fixed it.