c4-project / c4t

Runs concurrent C compiler tests
MIT License
1 stars 0 forks source link

Director instance observers are requested after the forwarder starts running #87

Closed MattWindsor91 closed 3 years ago

MattWindsor91 commented 3 years ago

Director instance observers are currently requested when the director starts running. This is not guaranteed to happen before the forwarder starts running, and this means that the forwarder thinks there is nothing forwarding to it, packs up, and no observations get forwarded.

This manifests as the results log and stat persister not receiving anything other than director-level events.

Should be easy to bodge a fix for this: make the director pre-allocate static bits of instances (including instance observers) during construction, and then fill the rest out later. It probably isn't worth teaching the forwarder to be able to add in instance observers dynamically.