search

c42f / tinyformat

Minimal, type safe printf replacement library for C++
537 stars 75 forks source link

Fix build warnings in header #1

Closed arsenm closed 12 years ago

arsenm commented 12 years ago

Mostly missing default case and unused parameters

c42f commented 12 years ago

Hi thanks for the pull request! Which version of clang are you using?

c42f commented 12 years ago

Ack, I accidentally made comments on the individual patches rather than the pull request page. I'll repeat them here.

[Edit] ah, scratch that, they've shown up after a refresh.

c42f commented 12 years ago

Ok, I've made a bit of a mess of the comments, but I did go back to put them on the pull request diffs page (otherwise they don't show up properly with context in the pull request web interface.)

If you can have a look at each of the queries that would be great. Alternatively I'm happy to do any remaining cleanup / warning removal - just let me know which version of clang you're using.

arsenm commented 12 years ago

I'm using clang 3.1 with -Weverything

c42f commented 12 years ago

I finally got some time to look over this again in detail, and merged various of your changes after some consideration.

Unfortunately it seems a bit impossible to silence all the warnings without uglifying the code or introducing warnings on other compilers. My aim is to have all compilers warning free on "reasonable" warning levels. To me that's -Wall for gcc and clang, and -W2 for MSVC. If there's specific warnings I didn't address which you really want to get rid of, feel free to submit a new pull request.