c42f / tinyformat

Minimal, type safe printf replacement library for C++
537 stars 75 forks source link

Use typename instead of class on TINYFORMAT_ARGTYPES? #63

Closed evandrocoan closed 4 years ago

evandrocoan commented 4 years ago

Should typename to be more generic than class?

https://github.com/c42f/tinyformat/blob/705e3f4e1de922069bf715746d35bd2364b1f98f/tinyformat.h#L418

c42f commented 4 years ago

No, they're equivalent in this context. typename is just longer.

c42f commented 4 years ago

I'm not sure there's anything really useful to change here, so I'll close this.

I agree that typename is more accurate terminology. But given that it's twice as long I tend to default to class instead for template type parameters.