c4deszes / ldfparser

LIN Description File parser written in Python
https://c4deszes.github.io/ldfparser/
MIT License
64 stars 26 forks source link

Fix incorrect endianness in array type signals encoding/decoding #126

Closed nuts4coffee closed 9 months ago

nuts4coffee commented 1 year ago

Brief

Use LSB order to encode/decode array-type signals. Please see https://github.com/c4deszes/ldfparser/issues/125 for the description from the spec.

Checklist

Resolves

Fixes #125

Evidence

image Capture from VehicleSpy, where the signal MyArraySignal1 with values [20000] is encoded to 0 0 2.

codecov[bot] commented 1 year ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (2fe6236) 96.28% compared to head (9892f6e) 96.42%.

:exclamation: Current head 9892f6e differs from pull request most recent head 391bd39. Consider uploading reports for the commit 391bd39 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #126 +/- ## ========================================== + Coverage 96.28% 96.42% +0.13% ========================================== Files 13 13 Lines 1453 1453 ========================================== + Hits 1399 1401 +2 + Misses 54 52 -2 ``` | [Flag](https://app.codecov.io/gh/c4deszes/ldfparser/pull/126/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Bal%C3%A1zs+Eszes) | Coverage Δ | | |---|---|---| | [3.10.0b1](https://app.codecov.io/gh/c4deszes/ldfparser/pull/126/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Bal%C3%A1zs+Eszes) | `96.42% <100.00%> (+0.13%)` | :arrow_up: | | [3.6](https://app.codecov.io/gh/c4deszes/ldfparser/pull/126/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Bal%C3%A1zs+Eszes) | `96.41% <100.00%> (+0.13%)` | :arrow_up: | | [3.7](https://app.codecov.io/gh/c4deszes/ldfparser/pull/126/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Bal%C3%A1zs+Eszes) | `96.41% <100.00%> (+0.13%)` | :arrow_up: | | [3.8](https://app.codecov.io/gh/c4deszes/ldfparser/pull/126/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Bal%C3%A1zs+Eszes) | `96.41% <100.00%> (+0.13%)` | :arrow_up: | | [3.9](https://app.codecov.io/gh/c4deszes/ldfparser/pull/126/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Bal%C3%A1zs+Eszes) | `96.41% <100.00%> (+0.13%)` | :arrow_up: | | [unittests](https://app.codecov.io/gh/c4deszes/ldfparser/pull/126/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Bal%C3%A1zs+Eszes) | `96.42% <100.00%> (+0.13%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Bal%C3%A1zs+Eszes#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

nuts4coffee commented 9 months ago

Close as master branch in fork repo has been reset. Will reopen from branch later.