c4deszes / ldfparser

LIN Description File parser written in Python
https://c4deszes.github.io/ldfparser/
MIT License
64 stars 26 forks source link

Support parsing of node attributes in J2602 LDF file #130

Closed nuts4coffee closed 9 months ago

nuts4coffee commented 9 months ago

Brief

Reference: J2602_3 Oct 2021:

image

Checklist

Resolves

Evidence

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (63ae6cc) 96.28% compared to head (b5eb268) 96.30%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #130 +/- ## ========================================== + Coverage 96.28% 96.30% +0.02% ========================================== Files 13 13 Lines 1453 1463 +10 ========================================== + Hits 1399 1409 +10 Misses 54 54 ``` | [Flag](https://app.codecov.io/gh/c4deszes/ldfparser/pull/130/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Bal%C3%A1zs+Eszes) | Coverage Δ | | |---|---|---| | [3.10](https://app.codecov.io/gh/c4deszes/ldfparser/pull/130/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Bal%C3%A1zs+Eszes) | `96.30% <100.00%> (+0.02%)` | :arrow_up: | | [3.11](https://app.codecov.io/gh/c4deszes/ldfparser/pull/130/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Bal%C3%A1zs+Eszes) | `96.30% <100.00%> (+0.02%)` | :arrow_up: | | [3.12](https://app.codecov.io/gh/c4deszes/ldfparser/pull/130/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Bal%C3%A1zs+Eszes) | `96.30% <100.00%> (+0.02%)` | :arrow_up: | | [3.6](https://app.codecov.io/gh/c4deszes/ldfparser/pull/130/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Bal%C3%A1zs+Eszes) | `96.30% <100.00%> (+0.02%)` | :arrow_up: | | [3.7](https://app.codecov.io/gh/c4deszes/ldfparser/pull/130/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Bal%C3%A1zs+Eszes) | `96.30% <100.00%> (+0.02%)` | :arrow_up: | | [3.8](https://app.codecov.io/gh/c4deszes/ldfparser/pull/130/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Bal%C3%A1zs+Eszes) | `96.30% <100.00%> (+0.02%)` | :arrow_up: | | [3.9](https://app.codecov.io/gh/c4deszes/ldfparser/pull/130/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Bal%C3%A1zs+Eszes) | `96.30% <100.00%> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Bal%C3%A1zs+Eszes#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

nuts4coffee commented 9 months ago

@c4deszes Could you please help review this change? I notice some pipeline jobs have failed but I don't think they're related to my changes. Please let me know if there is anythng to fix on my end. Thanks.